tzutils: tzdata provides py3:tzdata #53607
Merged
+7
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It doesn't matter anyway, since our python3-tzdata is almost empty and uses system zoneinfo. |
|
oh, |
|
that's not the same thing as tzdata i think |
|
Ah yes! Anyway, what is different between: |
|
/me removes |
|
classabbyamp
force-pushed
the
py3-tzdata
branch
from
4e11a56 to
a2252cd
Compare
according to the Python documentation[1], the `zoneinfo` module uses the system timezone data if available, and also provides an installable `tzdata` library on PyPi. Some Python packages (like pandas) spuriously always depend on this library. By having `tzdata` provide this py3: package, it would work around Python packages that make this mistake, and avoid needing to package `python3-tzdata` or set `noverifypydeps` (which would be overkill). [1]: https://docs.python.org/3/library/zoneinfo.html Close: void-linux#53607
We don't care if 2 timezones provides same zoneinfo as of current time being.
sgn
pushed a commit
that referenced
this pull request
Dec 23, 2024
according to the Python documentation[1], the `zoneinfo` module uses the system timezone data if available, and also provides an installable `tzdata` library on PyPi. Some Python packages (like pandas) spuriously always depend on this library. By having `tzdata` provide this py3: package, it would work around Python packages that make this mistake, and avoid needing to package `python3-tzdata` or set `noverifypydeps` (which would be overkill). [1]: https://docs.python.org/3/library/zoneinfo.html Close: #53607
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
according to the Python documentation, the
zoneinfomodule uses the system timezone data if available, and also provides an installabletzdatalibrary on PyPi. Some Python packages (like pandas) spuriously always depend on this library. By havingtzdataprovide this py3: package, it would work around Python packages that make this mistake, and avoid needing to packagepython3-tzdataor setnoverifypydeps(which would be overkill).@sgn, this is your package, what do you think?
Testing the changes